Code push has happened!

[mark]

Hi all, I'm preparing to do a code push. You can see the latest code tour here: https://dw-dev.dreamwidth.org/214638.html

Hang on to your hats!

Edit: The code has pushed! As always, please let us know if you see anything wonky or broken and we'll get on it!

Known Issues - Fixed 'em Maybe?

* Font size was way too small. We've tweaked them to be larger, but would welcome more feedback!
* Lack of ability to horizontally resize comment area. This has been fixed, you can drag the box horizontally again like you should be able to!
* A couple of style issues have been found and fixed.
* An issue affecting some Navigation strips has been fixed.
* An issue affecting syndicated accounts, proxied images, and a couple other worker related tasks were broken. They're better now.
* We've made some updates to the design of the comment reply form, we brought back the browse button, made the subject line full-width, and some other tweaks. Please let us know what you think!
* The RTE on the old create entry form is returned to service. A few more months, that's all we ask of you old friend...
* OpenID was broken, it's back.
* Button sizes are reset to default, we are no longer trying to make things line up. Let the ziggurat design pattern live on.
* Polls should show properly sized bars again.
* Lots more Android issues, we had to murder the unused spellcheck button to make it work out. Some weird interactions with differently sized elements and our ancient HTML.

Known Issues - Pending

* Related, some fields seem to have gone emo and are putting on heavy eyeliner (have bold, dark outlines). We're aware.

All known issues are being investigated and will be fixed! Please hang tight while we work on it :)

If you are reporting something visual, please let us know what browser/device you're on!

Comments

[saga]

Hi team! Only starting around today or the last couple of days, I have been unable to use custom CSS in the layouts. The ones that worked before will keep working, but if I use that exact same code in something new, it won't work. A few of my friends have noticed this. I can only speak for the ones in tofuhouse which I can confirm were working yesterday since I was told by those who have successfully added them into the custom CSS box. Has something been changed within the day?

Unfortunately my internet at home is broken so I can't provide desktop examples, but let me know what I can provide, thank you!

EDIT: I can confirm that if I get the original default CSS (like say of tectonic's fission):
1. Copy it into Custom CSS
2. uncheck use stylesheet.

That the resulting layout is broken and looks blank. I grabbed a copy of the original tectonic CSS and left it here: https://developmenthell.dreamwidth.org/543.html but this is affecting all layout styles. Thanks for your time!

EDIT 2: more of my friends have brought up that this is happening to more of the other custom layout codes they sourced from other communities, along with if they copied default CSS into the custom CSS box. Thanks again!

[denise]

This is *likely* because we changed some CSS around, but let me check with the people who know more about this than I do, heh.

EDIT: ahahaha nope. Okay, you ran into an Unexpected Side Effect Problem with the implementation of the new "@ mention people to turn it into a user tag". We'll get it fixed! In the meantime, you can tell people to search for all instances of:

<user name=font-face> / <user name=media>

and replace them with:

@font-face / @media

(This might not escape properly and I'm not gonna fight it if it doesn't. @ font-face and @ media without the spaces. And any other @ property you used in the layout. You probably see what happened, heh.)

You won't be able to fix it on your end by editing the post and correcting the CSS -- the conversion is being done at the time the entry is loaded, not at the time the entry is saved. We have to figure out what to do about it on our end.

That at-sign expansion at entry display time

[pauamma]

You won't be able to fix it on your end by editing the post and correcting the CSS -- the conversion is being done at the time the entry is loaded, not at the time the entry is saved. We have to figure out what to do about it on our end.

In addition to breaking all discussions of CSS going forward and backward, this does the same to all discussions of perl code, where both "at-sign foo" and "backslash at-sign foo" are very common idioms that should remain untouched. Using "don't autoformat" isn't really a solution, because it also breaks (IIRC) the "line break to <br />" conversions. While I can see the attraction of "at-sign exampleuser" for some people going forward the only 2 backward-compatible solutions that I see (but I may be missing some) are:
- make the at-sign expansion opt-in (making it opt-out won't work, because it still breaks backward compatibility)
- keep at-sign expansion for markdown and markdown only (which is another way of making it opt-in, I guess)

Re: That at-sign expansion at entry display time

[roadrunnertwice]

Most markdown implementations automatically escape otherwise problematic characters when they occur in code spans and code blocks. If we’re doing the username conversion after things arrive in HTML land, we probably need to make sure we’re excluding them from a similar set of elements — <code>, <pre>, possibly <textarea>, though wow, that one wouldn’t have occurred to me until today.

Re: That at-sign expansion at entry display time

[pauamma]

Hmm. I guess that solution would work in most cases, and if Afuna can live with https://afuna.dreamwidth.org/535807.html still being mangled (which I think it would be), so can I. I'll miss not being able to say "my dreamwidth email address" in entries and comments without some additional effort, but maybe I'll get used to that.

Re: That at-sign expansion at entry display time

[denise]

You can quick-escape by sticking a \ before the @, btw.

Re: That at-sign expansion at entry display time

[pauamma]

Yeah. Experience will show if I can remember to do that in time, going forward.

[saga]

I can definitely confirm that yesterday I did see it occur in the < code >, but it appears to look like @ now such as here https://developmenthell.dreamwidth.org/1387.html i'm not sure if I can work in CSS custom boxes yet since I only just looked. Thanks!

[denise]

We put in exceptions for CSS at-selectors this afternoon, yes!

[saga]

YAAAAAAS thank you so much!!

[pauamma]

Are you planning to put in exceptions for entry and comment content inside <code>...</code>, <pre>...</pre>, and <textarea>...</textarea> too, as mentioned in https://dw-maintenance.dreamwidth.org/78131.html?thread=3030835#cmt3030835 ? That would be great.

+1

[saga]

I agree with this as well; while it works for font_face and media now because they're exceptions, it would be great if every other @ call can remain looking like @username instead of calling it. I tried them out here: https://tofuhouse.dreamwidth.org/5879.html and since using textareas and codes are popular in coding communities, this might become a big hassle in the future.

Thanks for looking into this too, team.

Re: +1

[pauamma]

And another exemption is probably needed for content (or at least entries) in syndicated accounts.

[trobadora]

the new "@ mention people to turn it into a user tag"

I totally missed this! But am I getting it right that this means every past entry and comment that has a @ in it is getting mangled? :(

[denise]

It's new, Mark pushed it last night for testing with a wider range of user data than we can produce. It only triggers if the @ is the first character in the word, so it doesn't trigger in the middle of, say, an email address. (And you can escape it by putting a \ before the @whatever!)

[trobadora]

Thank you for the additional info! That looks like a great thing going forward, but I'm not that fond of it affecting affect past entries too. I don't suppose there's any way around that?

[denise]

Sadly no, but we may change more of the triggering conditions as we see more of how much past user data it messes up / how severely stuff gets messed up.

[archangelbeth]

Oh no, all my googly-eyed emoticons are going to break. OXD

_@
@_@

[saga]

Hi Denise, thanks for the heads up and all the workarounds! Since I just woke up (and had to get to a place with working internet...thanks workplace shhh) I just took a look and saw that I can copy/paste from textarea spaces again. Has this been fixed or still ongoing? Just to know when I can start messing around in posts.

This new functionality is amazing as well! Does it have options for external sites, like twitter and plurk? Thanks again!

[denise]

Yes, we put in exceptions for common CSS at-selectors (right now: font-face, media, and supports) this afternoon so you should be good to go without doing anything different.

I'm not 100% on the current details of the implementation because Mark just coded it but I think that's the ultimate goal, yeah.

[saga]

Excelleeeent thank you so much for this!! This will be super awesome.

And that's really cool! I can't wait to see it in action with the externals as well, lord knows how many times my sausage fingers mistype a bracket.

[momijizukamori]

yeah, if you add . after the username it'll become an external site one - so @ momijizukamori.plurk = momijizukamori

[saga]

thank you so much!!! this is wild and amazing.