mark: A photo of Mark kneeling on top of the Taal Volcano in the Philippines. It was a long hike. (Default)
Mark Smith ([staff profile] mark) wrote in [site community profile] dw_maintenance2019-06-22 08:10 pm

Code push has happened!

Hi all, I'm preparing to do a code push. You can see the latest code tour here: https://dw-dev.dreamwidth.org/214638.html

Hang on to your hats!

Edit: The code has pushed! As always, please let us know if you see anything wonky or broken and we'll get on it!

Known Issues - Fixed 'em Maybe?


* Font size was way too small. We've tweaked them to be larger, but would welcome more feedback!
* Lack of ability to horizontally resize comment area. This has been fixed, you can drag the box horizontally again like you should be able to!
* A couple of style issues have been found and fixed.
* An issue affecting some Navigation strips has been fixed.
* An issue affecting syndicated accounts, proxied images, and a couple other worker related tasks were broken. They're better now.
* We've made some updates to the design of the comment reply form, we brought back the browse button, made the subject line full-width, and some other tweaks. Please let us know what you think!
* The RTE on the old create entry form is returned to service. A few more months, that's all we ask of you old friend...
* OpenID was broken, it's back.
* Button sizes are reset to default, we are no longer trying to make things line up. Let the ziggurat design pattern live on.
* Polls should show properly sized bars again.
* Lots more Android issues, we had to murder the unused spellcheck button to make it work out. Some weird interactions with differently sized elements and our ancient HTML.

Known Issues - Pending


* Related, some fields seem to have gone emo and are putting on heavy eyeliner (have bold, dark outlines). We're aware.

All known issues are being investigated and will be fixed! Please hang tight while we work on it :)

If you are reporting something visual, please let us know what browser/device you're on!

[personal profile] confiscated 2019-06-23 04:31 am (UTC)(link)
Can you perhaps add a button for browsing icons vs clicking the icon itself? I don't mind it being there but I find it's unintuitive to have to click it to get that pop up when "random icon" is also still its own button.

Similarly, the issue with not being able to horizontally adjust the text area box past its set width - is that intended?
brokenallthelaws: (Default)

[personal profile] brokenallthelaws 2019-06-23 04:35 am (UTC)(link)
Yeah, +1-ing to the button for icon browsing. If I hadn't hovered the icon next to the comment box, I wouldn't have known to look there, and I'm seeing I'm not the only person having a "where is the browse" problem.
forgottenmercy: (Default)

[personal profile] forgottenmercy 2019-06-23 04:36 am (UTC)(link)
yet another +1 on the browse button
flurface: ♥️ (Default)

[personal profile] flurface 2019-06-23 04:37 am (UTC)(link)
+1 to the hoping that not being able to horizontally adjust the text area box is not intended, since I liked being able to do that.

[personal profile] confiscated 2019-06-23 04:57 am (UTC)(link)
I already see the size change, which is great! Thanks!

I know you guys are busy but just a few more suggestions:
- No zoom on the icon (it doesn't suit the slick look,) but a browse button under it or even a small text "browse" to launch the icon browser for those who are having hover issues, etc.
- Maybe move subject to it's line above or below (icon dropdown)? That way you could add browsing + random icon + quote to that line (below or above subject) for a crisper look. Having an icon choice to the left, to the top and to the bottom right is kinda messy.

Example:
(Icon dropdown) (random icon) (quote)
(full line for just comment header)
(text area)
(post comment / preview) (more options)
The old browser had it similar to that but with the header first, icon options second, then the text area. The eye doesn't really follow the current set up smoothly. Sry if this just sounds like complaining but I'm just having trouble adjusting and see others are too!

EDIT: Now the text in the comment boxes is a size too large? I'm on Chrome / Windows. It was fine when I posted this initial comment and is now flakey. But I'm gonna let you guys work on that as you will.
Edited 2019-06-23 05:02 (UTC)
toil: (Default)

[personal profile] toil 2019-06-23 05:02 am (UTC)(link)
hi, i'm so sorry, i know you're trying to help the original "too small" problem - you did, at first, but then another size change happened, and now the font inside the comment box is incredibly large. too big for comfort for a lot of us doing some testing.

can anything be done to go back a step?
toil: (Default)

[personal profile] toil 2019-06-23 05:21 am (UTC)(link)
ok as an update from my testing friends, the coding seems to affect different monitor sizes and screen resolutions differently, as it pertains to font size, comment box size, and i think even button size.

the font size inside the comment box is great for a lot of us now, for example, but for those with 16/17 inch screens and wider, it shrinks in relativity.

on mobile apps of the same browsers these users are using, it doesn't necessarily behave the same way - mobile chrome users report gigantic font appearance, so there may be another line of code that still needs implementing to mimic what you've done for PC/mac chrome.

just wanted to offer that to you guys for review purposes!
gairuki: (my best friend)

[personal profile] gairuki 2019-06-23 05:35 am (UTC)(link)
I'm one of the code testing friends with a widescreen 17in monitor, and as of this posting on my laptop the text is better for me in the box! It's not tiny or huge. I don't normally post from mobile however, and when someone told me about some issues there I thought I'd take a poke and just...

link is it supposed to be this huge? If so then fantastic! If not, I thought you'd like to know. (that's taken from a Motorola Moto Z2 Play Android in Mobile Chrome).
Edited (changed image to a link) 2019-06-23 05:35 (UTC)
criminaljustice: (268)

[personal profile] criminaljustice 2019-06-23 05:12 am (UTC)(link)
+1ing the icon browsing. especially the point that there's a "random icon" button which is likely used far less frequently.

Also clicking on the icon doesn't seem to work for people who don't have default icons and i... i dislike. please. let me live.
crossmyheartandhope: (Just shine a light into the wreckage)

[personal profile] crossmyheartandhope 2019-06-23 06:04 am (UTC)(link)
+1, I would love a browse button. I tend not to use default icons, so it looks like that means I'm not able to click the icon to browse? Which is somewhat inconvenient.
Edited 2019-06-23 06:04 (UTC)
clairvoyance: I've already forgotten yesterday's dream (Default)

[personal profile] clairvoyance 2019-06-23 06:25 pm (UTC)(link)
Would it be possible to at least leave the old style when the user clicks "more options"? That's how it is now, and I think it would be appreciated by a lot of people if the old style was accessible in that way. It's tried and tried and works for older computers and tons of browsers and configurations. I know I'll be very disappointed if it goes away entirely.
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)

[staff profile] denise 2019-06-23 06:29 pm (UTC)(link)
The reason that we're making changes is because the old views weren't good enough for a ton of people! (They seriously weren't, "this doesn't work on my phone" is the #1 issue people contact us about right now.) So, no, we won't keep the old comment form, because it's never good to have multiple versions (and part of this is combining all the various comment forms, because there are multiple code paths depending on what view you're looking at and that's part of the problem). But we will fix the bugs that people find.