code update

[mark]

I'll be doing a code push shortly. Since it has been a month since the last one, I expect this one will be a little turbulent. There's a lot of fixes, tweaks, and updates going live with this particular push.

As always, if you see something terribly wrong, open a support request or comment here and we'll take a look at what's going on.

Edit: Push complete.

Comments

[milkymoon]

That actually went rather smoothly! \o/

[msilverstar]

Could you give us more warning next time? Sometimes I lose half-written comments and such. Thanks

[albijuli]

wow, that was pretty smooth. I wasn't even aware that a codepush was comin'. :3

[afuna]

Oh hey, how do you end up losing the comments when the code push happens? Is it the "Invalid form submission" thing?

I'm asking because we just pushed something that re-generates the comment form, so you get your comment text back when you get "invalid form submission" -- and if that's not what's caused you to lose comments in the past, I'd like to hear about it so we can see if there's something else we can do :)

[gwenhyffar]

Hehe, you make it sound so exciting and then nothing happens!

[onyx_noir]

I'm noticing an inability to play embeded youtube videos when you're posting in comments on an entry. I tried it again just now after the update and they're still not working.

[denny]

The margins on my journal theme seem to have got larger, either that or I'm hallucinating again. Anyway, if they did then I guess that was probably deliberate on the part of whoever wrote it rather than being any kind of bug. No other effects noticed :)

[afuna]

Mmm, that was a conesquece of a bugfix. The problem before was that if you had the navstrip turned on in Transmogrified, it forced the middle part of the layout to expand to fill the screen. Since this was inconsistent with the behavior when the navstrip is turned off, we fixed it.

[denny]

Fair enough :)

I assume to get the old behaviour back I'd have to make a custom theme based on this one and play with the CSS? I'm not arguing with the bugfix, but I don't like empty margins :)

[liv]

I had a similar problem. You don't need to go as far as making a custom theme, you can just add CSS to the CSS box, if you like. You need to set the width, and possibly the margins, for an element called #container.

[afuna]

Liv, can you write something up for dw_styles? I suspect we'll get some questions re: this, so it'd be useful if we could post an entry to point people to.

[gchick]

#container {margin: 0;}

[denny]

That did it - thanks very much :)

[denny]

That should be 0px shouldn't it?

[denny]

Just margin: 0px; seems to do it, without specifying the width. Assuming you want full page width, of course.

[gchick]

Just 0 works (which wouldn't be the case if it were >0, of course) -- I tend to avoid fixed measurements like pixels and points whenever possible for both design and accessibility reasons, but that's a bit of a preference thing. (As a total aside, the original measurement you're replacing with that zero is expressed as a percentage, not px.)

[artisan447]

Thank you! I don't know anything about anything you're talking about but I also didn't like the bigger margins and now they're gone! :)

[trixtah]

Ugh, yes. Now my 1024 x 768 screen is looking much smaller. I hate narrow centre columns - time to see if there's such a thing as a non-fixed-width version.

[denny]

Check the replies to my comment and you'll find the CSS code to fix it, along with a link to the page where you need to insert that code.

[matgb]

Heh, so it looked good before because of a bug? It had never occured to me to test a layout with Navstrip off, guess I should given people can turn it off on DW, it's always on on my LJ.

Cool, I think. Thx, miss_s_b will be grateful when she awakes.

[afuna]

Hehehe, yeah. Though most of them shouldn't be affected; just the ones that set their margins the way that Transmogrified used to (on the body, not on the #container div, or whatever the layout equivalent is)

[willow]

My layout borked around 8am EST, so way before the codepush, I believe.

[afuna]

Broke in what way?

[willow]

I'm using Transmogrified and the entry field area has shifted and indented in from the left causing the entry field to become smaller. It looks a lot like LJ's Disjointed actually. With floaty bits of text in the middle of the screen.

Trying to pick another theme and then returning to Transmogrified did not help.

[logospilgrim]

Ah, thank you... That worked beautifully.