Code push has happened!

[mark]

Hi all, I'm preparing to do a code push. You can see the latest code tour here: https://dw-dev.dreamwidth.org/214638.html

Hang on to your hats!

Edit: The code has pushed! As always, please let us know if you see anything wonky or broken and we'll get on it!

Known Issues - Fixed 'em Maybe?

* Font size was way too small. We've tweaked them to be larger, but would welcome more feedback!
* Lack of ability to horizontally resize comment area. This has been fixed, you can drag the box horizontally again like you should be able to!
* A couple of style issues have been found and fixed.
* An issue affecting some Navigation strips has been fixed.
* An issue affecting syndicated accounts, proxied images, and a couple other worker related tasks were broken. They're better now.
* We've made some updates to the design of the comment reply form, we brought back the browse button, made the subject line full-width, and some other tweaks. Please let us know what you think!
* The RTE on the old create entry form is returned to service. A few more months, that's all we ask of you old friend...
* OpenID was broken, it's back.
* Button sizes are reset to default, we are no longer trying to make things line up. Let the ziggurat design pattern live on.
* Polls should show properly sized bars again.
* Lots more Android issues, we had to murder the unused spellcheck button to make it work out. Some weird interactions with differently sized elements and our ancient HTML.

Known Issues - Pending

* Related, some fields seem to have gone emo and are putting on heavy eyeliner (have bold, dark outlines). We're aware.

All known issues are being investigated and will be fixed! Please hang tight while we work on it :)

If you are reporting something visual, please let us know what browser/device you're on!

Comments

Your ETA2

[pauamma]

There was a change (issue 1852 in this code tour) that added stuff to the notification time column. Is that what you're referring to?

[bookkeeper]

Essentially it's the DWtools Chrome extension that's borking things up.

Without DWtools enabled: everything is perfectly aligned


With DWtools enabled (PAID ACCOUNT): everything is still perfectly aligned


With DWtools enabled (FREE ACCOUNT): the bottom line under the comment box is where things go wonky


^note the hovering 'browse' option in the middle of everything heh

[momijizukamori]

gdi I spent a lot of time getting that navbar nice and aligned.

I just noticed a possibly-related issue in Trifecta, which seems to suggest something in one of the core layers is at fault, so I will go digging.

Re: +1

[mycenae]

I keep trying to click "random icon" instead of post comment. (Which TBF is my own fault using DW tools which is super messed up now) but even without the extension turned on, IDK why "random icon" is at the bottom that far removed from the icon selection in general, or why "quote" is at the bottom with the comment finalization options when that's not when that's generally used.

In general, it just seems like it makes things more complicated than they need to be. And some of that may be me resistant to change, and I'll accept a measure of that, but when a good half of this site runs in comments (at least for a good number of us), this seems like a strange change to push out of nowhere.

[alexseanchai]

nod nod :)

Re: Your ETA2

[alexseanchai]

yes, but also, no? it's a visual layout thing? which may be a consequence of adding that timestamp info and my problem is it's Different, not anything anyone should worry about; I honestly can't tell

ETA: no there is almost definitely something potentially worrisome going on here, I did not used to need a horizontal scroll bar

[roadrunnertwice]

Hmm, I think that's part of trying to fix the Dramatic Woodchuck zoom — the best info I could find said we had to set the font to 16px on iOS if we didn't want it to slam the viewport around like a carnival ride, and that held true on the devices I was able to test with.

Do you have any idea whether the iPad Pros have a different threshold for doing that? It would make sense, with the bigger screen, but I only have an old iPad 4 running iOS 10, so I can't experiment. Anyway, if we could pin down the auto-zoom threshold for iPads, I bet we could refine the media query and exclude them from the "go yell-size" rule.

+1

[captainmaterial]

I agree with this, it's nice having that link to the icon page. Mostly because when I'm mobile I could never get the preview icon box to work for me correctly. (But that now seems to be fixed?) But it was still nice to be able to go to it.

[zarahjoyce]

This is also my problem! I'm using Google Chrome.

[anaraine]

i'm really happy this isn't intended behavior, but also i feel like i've been complaining about this layout a lot during recent code pushes so i also want to shoot you some praise that i still think this style is really awesome, ok? thanks for not abandoning it!

Thank you for all of your hard work!

[firstofitskind]

Firefox 67.0.3 on Windows 10 and same.

My reading page looks like this:

Re: +1

[novembermond]

right now I keep clicking wrong buttons when I try to go for random icon. I also think those buttons should be at the top not on the bottom but I guess they were going for a smooth layout.

[ilyena_sylph]

Oh for goodness sake, there I went and messed up my comment-ing.

The width of all the boxes (icon dropdown, subject, and text area) seems weird to me (as in, it's less than half my monitor width and that doesn't seem how it was?).

Also I'm not really loving 'random icon' being down in the weeds with the quote button. But it's not horridly broken or anything, just... Meh?

<3 y'all.

ETA: oh Ew. When I clicked edit comment? Things went really weird and ugly. I'll grab a screenshot. ETA3: By 'weird and ugly' I mean the bolding around the subject and reason for edit boxes.



ETA4: right. Chrome I have nfi what version, Windows 10.

+1

[niespodzianka]

agree

+1

[diabolicaloser]

I also like this idea, since I'm not a fan of how the little preview icon grows when hovered over. Having the browse button stay a button would keep it uniform with the other buttons as well!

[roadrunnertwice]

We should have the resize thing fixed! That was a bug.

[confiscated]

Also just noticing when commenting on the new form, there's no easy link to my journal. I think I remember that being available before (like helplessworld at the top of the form) and it's just kind of irksome because if I want to reference something in my journal, I have to scroll all the way up to the top of the page now vs just right clicking the user icon at the top of my comment.

I could be mistaken about it but even still a ("commenting as...") function would be nice.

[flurface]

Yeah, it's working now! Thanks.

[doranwen]

Well, it's also possible that it existed before and I just never noticed, LOL! (It is a rather tiny visual glitch that you almost have to be looking for to have it brought to one's attention.) I was looking particularly to see if everything looked right because of the post, and that's when I noticed it. But if you weren't aware of this existing before (and I would assume someone else would have said something), then I wish you the best of luck finding the change that caused it. :)

Also, I should've taken a picture of the comment box because I'm seeing another issue there (which I was too focused on commenting the first time to have it in my conscious awareness) - the More Options button is insisting on hanging down on a second line, no matter how wide I drag the comment box. And unlike the person above who said it was DWTools that borked things up, I do not have any extensions on my Firefox that should be rearranging how DW looks at all. Let me know if you need a screenshot of this or if my description of the issue is clear enough.

+1

[diabolicaloser]

I didn't even notice that feature was gone at first since I've only been using my paid account, but having a quick link to your icon page was definitely useful for free accounts!

[momijizukamori]

I have a guess as to what caused this, and I will dig into how to fix it shortly

[swankyfunk]

You're right, I do miss the journal name at the top of the form! I often switch between a handful of different journals, and it was always a good reminder (sometimes the icon just isn't enough) of which journal I was using. Thank you for bringing this up, I knew this new form was looking a little sparse.

[momijizukamori]

Honestly it remains one of my favorites, so no plans to abandon it!

I think I found the offending line, and I'm still not sure why it's causing that particular weirdness, but it definitely is.

[firstofitskind]

Thank you! It's marginally (... heh) better if I expand my Firefox window to fullscreen (I usually operate in a split-screen mode with the browser in half and Discord or w/e in the other half), but I have the same issue in Safari when browsing on mobile as well.

Re: Your ETA2

[pauamma]

Uh. OK, afraid it's beyond me then, except to say that with my browser (Chromium) and choice of site skin (Lynx) I'm not seeing a horizontal scrollbar with the browser window maximized.