Code push underway

[denise]

Tonight's code push is underway! We'll update this entry when we're done.

EDIT: And we're done! As always, we're watching for issues, but let us know of any problems.

Known issues:

* A dw_news post was posted just before 0800 EDT (see in your time zone). Comment notifications may be delayed for up to an hour or two, due to the high volume of notifications generated by each news post. Please don't worry about missing notifications until at least 1000 EDT.

* If you have a custom journal style, and you're seeing entries in the site default (Practicality/Neutral Good) rather than your custom layout, please recompile your layout layer and then try again. (This code push included S2 changes; we recompiled all the site styles, but we can't force custom styles to recompile.)

Comments

[nenya_kanadka]

Hi,

I'm having problems with the comments on my posts. All except the top-level comments seem to have disappeared? If I use flat-view, they show up fine, but if I'm using normal view I can only see the top-level comments. If I click through to a thread, I still only see the first comment.

http://nenya-kanadka.dreamwidth.org/104799.html for example.

[fu]

Hmm, that's strange. I'll take a look.

[denise]

Hm. I'm seeing non-top-level comments there -- is it possible you hit the "top-level comments only" link and didn't realize it?

Try loading the entry in a new tab, and clear your browser cache first just to be sure.

(EDIT: As afuna and I collide! If she was seeing what you were reporting and I wasn't, that's more mysterious. Lemme get back to you. (But try clearing your cache anyway just to be sure!))

EDIT, again: nevermind, we figured out why I wasn't seeing it happen and fu and mark were! The comments will show up in site-skinned comment pages, just not in journal-styled comment pages. Looking into why that is now.)

[nenya_kanadka]

Thanks for checking into it!

Yeah, I've made sure I'm not in "top-level comments only" and I've cleared my cache. My wife on a different computer/in a different city is seeing the same thing. (Her journal at muccamukk seems unaffected, though.)

[denise]

Yup, we've figured out what it was and should have a fix out shortly. We hope. :)

[nenya_kanadka]

Thanks, it seems to be working for me again! Appreciate the quick help. <3

[denise]

You're welcome! Thank you for helping us to find it :)

[fu]

Fixed now, thanks for letting us know!

[nenya_kanadka]

Thank you so much!

[dancing_serpent]

My custom layer doesn't show like normal. For example, when I open community comment pages, I don't get to see them in my style like usual, not even in the community's style or the site style. Instead I get the Practicality Neutral Good theme.

[denise]

Hmmmm. That's odd, but I think I know what might have happened there. Lemme ping fu and get back to you; it probably won't be an immediate fix.

EDIT: Also, stab in the dark: can you try recompiling your custom layer and see if that fixes it?

[dancing_serpent]

Okay, I edited my custom layer and now it seems to work fine again. I'll keep my eyes in it. Thanks :)

[denise]

yay, glad that fixed it. I've edited a notice into the post that anyone else with a custom layout and display probs should try recompiling. (Basically, this push included a bunch of changes to S2-the-core-language -- Mark wrote a whole new function into the language -- and I'm guessing that resulted in problems with custom layouts needing to be recompiled.)

[lienne]

AFAIK, the alicornutopia community hasn't touched its default style at all, so I don't think this is an issue that recompiling would fix:

Previously broken entry in site style - fixed; same entry in community style - eek!

Previously broken entry in site style - fixed; same entry in community style - eek!

In case you're not seeing the eek, I can provide screenshots on request, but the basic problem is that the entry takes a god's age to load and then shows up with all comment threads after the first one shoved up against the side of the frame, the community sidebar nowhere to be found, and the start of the second-and-subsequent-comment-threads block overlaid on the same space as the entry text and first comment thread.

[denise]

Oh, my, that's ... something, all right!

That one's gonna take some more digging, and the people who can do the digging (probably fu; I sort of look at the style system and back away slowly) have hit the end of their day, so it'll probably be this evening or so until we can figure that one out. In the meantime, I suggest you make friends with ?style=site, yes. Sorry about that!

[juliet316]

Suggestion if your on IE (I'm on 9, so I don't know if this will fix this for everybody on IE): If you turn compatibility view, it does seem to fix the issue in the community style. Admittedly, it's a band-aid, and not everyone has IE, but it's at least one solution for some people while you guys work on a permanent fix.

[lienne]

No worries! It is a vast improvement on the previous situation. XD

[denise]

I have to say: I love having all you RPers around on the site for so many reasons, but one of the big ones is that we can always count on you to break the site in new and inventive ways.

(That is absolutely not sarcasm! No matter how carefully you code something, it always exhibits strange bugs when it meets real-world data, because people are wonderfully inventive and do a thousand weird, bizarre, fantastic things that you never dreamed were possible with anything that you make, and it is often really freaking difficult to identify and track down those bugs, because they only happen when the moon is in the seventh house or when someone spills their coffee on their keyboard at the precise moment the cat is walking across it, etc. Or, you know, when someone has an entry with 2000 comments on it and only like three of them are top-level comments. Y'all are walking, breathing, typing, glorious edge cases and I love you all.)

[lienne]

Bwahahahahahahaha. I am only too happy to help. :D

[fu]

Fixed and thank you for the links :D